Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 396173002: Cleanup dependencies on device/ (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
keybuk, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup dependencies on device/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284858

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : fix build, rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M chrome/browser/extensions/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/api/api.gyp View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M extensions/common/extension.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
keybuk
lgtm
6 years, 5 months ago (2014-07-17 17:54:06 UTC) #1
Lei Zhang
On 2014/07/17 17:54:06, keybuk wrote: > lgtm Thanks, but this CL is not 100% ready ...
6 years, 5 months ago (2014-07-17 17:57:53 UTC) #2
Lei Zhang
gyp file stupidity fixed, ready for review.
6 years, 5 months ago (2014-07-17 22:39:30 UTC) #3
keybuk
still lgtm
6 years, 5 months ago (2014-07-22 17:52:49 UTC) #4
Lei Zhang
On 2014/07/22 17:52:49, keybuk wrote: > still lgtm Thanks, yoz?
6 years, 5 months ago (2014-07-22 18:36:39 UTC) #5
Yoyo Zhou
LGTM for extensions
6 years, 5 months ago (2014-07-22 21:14:57 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-22 21:16:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/396173002/40001
6 years, 5 months ago (2014-07-22 21:18:38 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 22:19:46 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 22:21:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/29719) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/31759)
6 years, 5 months ago (2014-07-22 22:21:24 UTC) #11
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-22 23:47:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/396173002/60001
6 years, 5 months ago (2014-07-22 23:49:49 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:19:41 UTC) #14
Message was sent while issue was closed.
Change committed as 284858

Powered by Google App Engine
This is Rietveld 408576698