Issue 396153003: Oilpan: fix Windows build after r178431.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396153003: Oilpan: fix Windows build after r178431. (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, haraken, wibling-chromium

CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Oilpan: fix Windows build after r178431. With http://crrev.com/406523002 making GarbageCollectedMixin a non-abstract class, MSVC elicits a warning that DLL exported GCMixin classes have a base class that isn't DLL exported. Add the needed annotation to GarbageCollectedMixin to address (as warnings are considered as errors.) R=haraken@chromium.org,wibling@chromium.org BUG=382557 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178439

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/platform/heap/Visitor.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/396153003/1

6 years, 5 months ago (2014-07-18 14:19:19 UTC) #5

Message was sent while issue was closed.

Change committed as 178439