Added second Google search expansion case to key_silk_pages

Added second Google search expansion case to key_silk_pages

BUG=377933, 377921
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290693

[wiltzius, 2014-07-16 05:43:47]

PTAL.

Note that pylint is complaining about my non-standard use of super to call the
class's parent's parent's constructor. I don't know if this is a valid pattern
or not, but it seems to work as expected...

[dtu, 2014-07-16 06:19:34]

On 2014/07/16 05:43:47, wiltzius wrote:
> PTAL.
> 
> Note that pylint is complaining about my non-standard use of super to call the
> class's parent's parent's constructor. I don't know if this is a valid pattern
> or not, but it seems to work as expected...

One possibility is to create a base class common to both of them.

[wiltzius, 2014-08-04 21:15:31]

On 2014/07/16 06:19:34, dtu wrote:
> On 2014/07/16 05:43:47, wiltzius wrote:
> > PTAL.
> > 
> > Note that pylint is complaining about my non-standard use of super to call
the
> > class's parent's parent's constructor. I don't know if this is a valid
pattern
> > or not, but it seems to work as expected...
> 
> One possibility is to create a base class common to both of them.

OK, easy enough. PTAL, thanks!

[wiltzius, 2014-08-11 21:12:29]

On 2014/08/04 21:15:31, wiltzius wrote:
> On 2014/07/16 06:19:34, dtu wrote:
> > On 2014/07/16 05:43:47, wiltzius wrote:
> > > PTAL.
> > > 
> > > Note that pylint is complaining about my non-standard use of super to call
> the
> > > class's parent's parent's constructor. I don't know if this is a valid
> pattern
> > > or not, but it seems to work as expected...
> > 
> > One possibility is to create a base class common to both of them.
> 
> OK, easy enough. PTAL, thanks!

Ping, look OK now?

[Sami, 2014-08-12 11:38:52]

lgtm with one question about scrollIntoView.

https://codereview.chromium.org/396153002/diff/20001/tools/perf/page_sets/key...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/396153002/diff/20001/tools/perf/page_sets/key...
tools/perf/page_sets/key_silk_cases.py:412: def NavigateWait(self,
action_runner):
µ-nit: NavigateAndWait?

https://codereview.chromium.org/396153002/diff/20001/tools/perf/page_sets/key...
tools/perf/page_sets/key_silk_cases.py:428:
"document.getElementById('%s').scrollIntoView()" % card_id)
Do we need to pass in true here to make sure the element is scrolled all the way
to the top?

[wiltzius, 2014-08-19 20:31:51]

On 2014/08/12 11:38:52, Sami wrote:
> lgtm with one question about scrollIntoView.
> 
>
https://codereview.chromium.org/396153002/diff/20001/tools/perf/page_sets/key...
> File tools/perf/page_sets/key_silk_cases.py (right):
> 
>
https://codereview.chromium.org/396153002/diff/20001/tools/perf/page_sets/key...
> tools/perf/page_sets/key_silk_cases.py:412: def NavigateWait(self,
> action_runner):
> µ-nit: NavigateAndWait?
> 
>
https://codereview.chromium.org/396153002/diff/20001/tools/perf/page_sets/key...
> tools/perf/page_sets/key_silk_cases.py:428:
> "document.getElementById('%s').scrollIntoView()" % card_id)
> Do we need to pass in true here to make sure the element is scrolled all the
way
> to the top?

I believe that 'true' is the default value?

http://dev.w3.org/csswg/cssom-view/#dom-element-scrollintoview

[wiltzius, 2014-08-19 21:52:17]

The CQ bit was checked by wiltzius@chromium.org

[commit-bot: I haz the power, 2014-08-19 21:53:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wiltzius@chromium.org/396153002/20001

[commit-bot: I haz the power, 2014-08-19 23:09:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-19 23:26:20]

Committed patchset #2 (20001) as 290693