Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: tests/FontNamesTest.cpp

Issue 396143004: Add a working SkFontMgr_fontconfig. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove T& operator* from SkAutoTCallVProc. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ports/SkFontMgr_fontconfig.cpp ('K') | « tests/FontHostTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/FontNamesTest.cpp
diff --git a/tests/FontNamesTest.cpp b/tests/FontNamesTest.cpp
index e4966b07a7c3af1eef8cf84da7ce9dc0ebe3684b..5c314e4e7e255020ac31e7ff8bb76e6d6c5e4d67 100644
--- a/tests/FontNamesTest.cpp
+++ b/tests/FontNamesTest.cpp
@@ -152,10 +152,6 @@ static void test_systemfonts(skiatest::Reporter* reporter, bool verbose) {
set->getStyle(j, &fs, &sname);
SkAutoTUnref<SkTypeface> typeface(set->createTypeface(j));
- if (NULL == typeface.get()) {
- //TODO: SkFontMgr_fontconfig always returns NULL?
- continue;
- }
SkString familyName;
typeface->getFamilyName(&familyName);
@@ -169,7 +165,7 @@ static void test_systemfonts(skiatest::Reporter* reporter, bool verbose) {
while (familyNamesIter->next(&familyNameLocalized)) {
if (verbose) {
SkDebugf("(%s) <%s>\n", familyNameLocalized.fString.c_str(),
- familyNameLocalized.fLanguage.c_str());
+ familyNameLocalized.fLanguage.c_str());
}
}
« src/ports/SkFontMgr_fontconfig.cpp ('K') | « tests/FontHostTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698