Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 396133002: ui/gfx: cleanup: change a function name for readability (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ui/gfx: cleanup: change a function name for readability ConvertSkiatoRGBA in png_coder.cc calls gfx::ConvertSkiaToRGBA. It's little bit confusing. For readability sake, I change ConvertSkiatoRGBA to ConvertSkiaToRGBA. BUG=NONE TEST=gfx_unittests --gtest_filter="PNGCodec*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283824

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/gfx/codec/png_codec.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 40 (0 generated)
hyunki
Please take a look. This is simple cleanup. Thanks. :)
6 years, 5 months ago (2014-07-16 03:02:18 UTC) #1
hyunki
Ping. PTAL for this simple patch. Thank you. :)
6 years, 5 months ago (2014-07-16 15:30:56 UTC) #2
erg
lgtm
6 years, 5 months ago (2014-07-16 17:22:45 UTC) #3
hyunki
Thanks for the review.
6 years, 5 months ago (2014-07-16 18:29:55 UTC) #4
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-16 18:29:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/1
6 years, 5 months ago (2014-07-16 18:31:51 UTC) #6
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-16 19:01:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
6 years, 5 months ago (2014-07-16 19:06:45 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 22:06:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 22:13:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80379)
6 years, 5 months ago (2014-07-16 22:13:56 UTC) #11
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-16 22:46:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
6 years, 5 months ago (2014-07-16 22:50:06 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 22:58:29 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 23:03:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80399)
6 years, 5 months ago (2014-07-16 23:03:44 UTC) #16
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-16 23:31:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
6 years, 5 months ago (2014-07-16 23:32:22 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 23:45:20 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 01:07:51 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80411)
6 years, 5 months ago (2014-07-17 01:07:52 UTC) #21
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-17 01:08:40 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
6 years, 5 months ago (2014-07-17 01:11:27 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 01:31:01 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 01:35:00 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80430)
6 years, 5 months ago (2014-07-17 01:35:01 UTC) #26
hyunki
Below error is observed. ** Presubmit ERRORS ** Missing LGTM from an OWNER for these ...
6 years, 5 months ago (2014-07-17 02:21:15 UTC) #27
hyunki
Below error is observed. ** Presubmit ERRORS ** Missing LGTM from an OWNER for these ...
6 years, 5 months ago (2014-07-17 02:21:19 UTC) #28
hyunki
On 2014/07/17 02:21:19, hyunki wrote: > Below error is observed. > > ** Presubmit ERRORS ...
6 years, 5 months ago (2014-07-17 06:40:54 UTC) #29
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-17 15:55:43 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
6 years, 5 months ago (2014-07-17 15:56:25 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 16:44:26 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 16:47:03 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80584)
6 years, 5 months ago (2014-07-17 16:47:04 UTC) #34
Elliot Glaysher
lgtm
6 years, 5 months ago (2014-07-17 17:10:57 UTC) #35
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-17 18:30:16 UTC) #36
hyunki
The CQ bit was unchecked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-17 18:30:16 UTC) #37
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-17 18:30:19 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
6 years, 5 months ago (2014-07-17 18:33:33 UTC) #39
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 18:41:24 UTC) #40
Message was sent while issue was closed.
Change committed as 283824

Powered by Google App Engine
This is Rietveld 408576698