|
|
Created:
6 years, 5 months ago by hyunki Modified:
6 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Descriptionui/gfx: cleanup: change a function name for readability
ConvertSkiatoRGBA in png_coder.cc calls gfx::ConvertSkiaToRGBA.
It's little bit confusing.
For readability sake,
I change ConvertSkiatoRGBA to ConvertSkiaToRGBA.
BUG=NONE
TEST=gfx_unittests --gtest_filter="PNGCodec*"
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283824
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 40 (0 generated)
Please take a look. This is simple cleanup. Thanks. :)
Ping. PTAL for this simple patch. Thank you. :)
lgtm
Thanks for the review.
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/1
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
Below error is observed. ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: ui/gfx/codec/png_codec.cc
Below error is observed. ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: ui/gfx/codec/png_codec.cc
On 2014/07/17 02:21:19, hyunki wrote: > Below error is observed. > > ** Presubmit ERRORS ** > Missing LGTM from an OWNER for these files: > ui/gfx/codec/png_codec.cc erg@, Could you review again with chromium.org account? Thanks.
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
lgtm
The CQ bit was checked by hyunki.baik@samsung.com
The CQ bit was unchecked by hyunki.baik@samsung.com
The CQ bit was checked by hyunki.baik@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/396133002/20001
Message was sent while issue was closed.
Change committed as 283824 |