Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: src/messages.js

Issue 396063008: Error.captureStackTrace should define "stack" property as configurable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-393988.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index 28af372b7f2fbc2f1897222e4b9b32eebda4ca57..ee5b1950a7f2bd6155eca93b2a60240cf5c785f4 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -1144,7 +1144,8 @@ var StackTraceSetter = function(v) {
var captureStackTrace = function captureStackTrace(obj, cons_opt) {
// Define accessors first, as this may fail and throw.
ObjectDefineProperty(obj, 'stack', { get: StackTraceGetter,
- set: StackTraceSetter});
+ set: StackTraceSetter,
+ configurable: true });
%CollectStackTrace(obj, cons_opt ? cons_opt : captureStackTrace);
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-393988.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698