Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 396063007: Ship image-rendering: pixelated to stable. (Closed)

Created:
6 years, 5 months ago by jackhou1
Modified:
6 years, 5 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, Mike Lawther (Google), Timothy Loh
Project:
blink
Visibility:
Public.

Description

Ship image-rendering: pixelated to stable. This also adds the value to DevTools. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zSasd2LL8Mc BUG=317991, 106662, 260739, 134040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178653

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +1 line, -1 line 1 comment Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
jackhou1
timloh, please review for OWNERS vsevik, please review for DevTools
6 years, 5 months ago (2014-07-17 00:01:21 UTC) #1
Timothy Loh
I don't have Source/platform OWNERS; so +eseidel :)
6 years, 5 months ago (2014-07-17 02:10:07 UTC) #2
jackhou1
eseidel, vsevik, Ping
6 years, 5 months ago (2014-07-18 22:23:03 UTC) #3
eseidel
lgtm https://codereview.chromium.org/396063007/diff/1/Source/devtools/front_end/sdk/CSSMetadata.js File Source/devtools/front_end/sdk/CSSMetadata.js (right): https://codereview.chromium.org/396063007/diff/1/Source/devtools/front_end/sdk/CSSMetadata.js#newcode406 Source/devtools/front_end/sdk/CSSMetadata.js:406: "auto", "optimizeSpeed", "optimizeQuality", "pixelated" This feels like something ...
6 years, 5 months ago (2014-07-21 23:13:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/396063007/1
6 years, 5 months ago (2014-07-21 23:14:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 00:34:14 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 01:37:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30577)
6 years, 5 months ago (2014-07-22 01:37:47 UTC) #8
lushnikov
devtools lgtm @eseidel, agreed, and we should have it one day, but it's not on ...
6 years, 5 months ago (2014-07-22 08:55:02 UTC) #9
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 5 months ago (2014-07-22 12:30:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/396063007/1
6 years, 5 months ago (2014-07-22 12:31:03 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 13:10:19 UTC) #12
commit-bot: I haz the power
Change committed as 178653
6 years, 5 months ago (2014-07-22 14:23:44 UTC) #13
jackhou1
6 years, 2 months ago (2014-09-25 05:48:48 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/604683003/ by jackhou@chromium.org.

The reason for reverting is: The bug affecting canvases also affects images that
become compositor layers. Unshipping until it's fixed..

Powered by Google App Engine
This is Rietveld 408576698