Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java

Issue 396063006: Mojo: Always suffix int literals with L in generated Java bindings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: lstrip(' +') Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
diff --git a/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java b/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
index 330c0847536017a8cd6084510403a04befa73b1d..bd78708dfb5630b32e535da076c6b9fa38b682de 100644
--- a/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
+++ b/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
@@ -180,7 +180,7 @@ public class BindingsTest extends TestCase {
checkField(DefaultsTest.class.getField("a3"), short.class, test, (short) 34567);
checkField(DefaultsTest.class.getField("a4"), int.class, test, 123456);
checkField(DefaultsTest.class.getField("a5"), int.class, test, (int) 3456789012L);
- checkField(DefaultsTest.class.getField("a6"), long.class, test, 111111111111L);
+ checkField(DefaultsTest.class.getField("a6"), long.class, test, -111111111111L);
// -8446744073709551617 == 9999999999999999999 - 2 ^ 64.
checkField(DefaultsTest.class.getField("a7"), long.class, test, -8446744073709551617L);
checkField(DefaultsTest.class.getField("a8"), int.class, test, 0x12345);
@@ -200,6 +200,9 @@ public class BindingsTest extends TestCase {
assertNotNull(test.a22);
checkField(DefaultsTest.class.getField("a22"), Thing.class, test, test.a22);
+ checkField(DefaultsTest.class.getField("a23"), long.class, test, -1);
+ checkField(DefaultsTest.class.getField("a24"), long.class, test, 0x123456789L);
+ checkField(DefaultsTest.class.getField("a25"), long.class, test, -0x123456789L);
}
/**

Powered by Google App Engine
This is Rietveld 408576698