Mojo: Always suffix int literals with L in generated Java bindings.

Mojo: Always suffix int literals with L in generated Java bindings.

BUG=394186
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283903

[qsr, 2014-07-16 09:08:39]

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_java_generator.py:244: if
kind_spec.startswith('i') or kind_spec.startswith('u'):
What would happen for enum value >= 2**31?
Or is it disallowed?

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_java_generator.py:248: except
ValueError:
Hum... You need this when an integer reference a constant or something like
this, don't you? Does this mean we should get more information here instead of
relying on an exception?

[Sam McNally, 2014-07-16 09:38:49]

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_java_generator.py:244: if
kind_spec.startswith('i') or kind_spec.startswith('u'):
On 2014/07/16 09:08:38, qsr wrote:
> What would happen for enum value >= 2**31?
> Or is it disallowed?

I expect they would be treated the same as uint32 values >= 2**31. Enum values
>= 2**32 seem to break C++ compile so I guess those are disallowed.

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_java_generator.py:248: except
ValueError:
On 2014/07/16 09:08:38, qsr wrote:
> Hum... You need this when an integer reference a constant or something like
> this, don't you? Does this mean we should get more information here instead of
> relying on an exception?

References to other constants or enum values are handled by the NamedValue case
above. This was just in case values that Python doesn't like as literals are
allowed, but upon further inspection the only problem cases are leading pluses
and spaces.

[qsr, 2014-07-16 09:41:36]

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/396063006/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_java_generator.py:248: except
ValueError:
On 2014/07/16 09:38:49, Sam McNally wrote:
> On 2014/07/16 09:08:38, qsr wrote:
> > Hum... You need this when an integer reference a constant or something like
> > this, don't you? Does this mean we should get more information here instead
of
> > relying on an exception?
> 
> References to other constants or enum values are handled by the NamedValue
case
> above. This was just in case values that Python doesn't like as literals are
> allowed, but upon further inspection the only problem cases are leading pluses
> and spaces.

 Thanks.

https://codereview.chromium.org/396063006/diff/20001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/396063006/diff/20001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/mojom_java_generator.py:247: if not
isinstance(number, (int, long)):
Should you just raise here? What is the legit case that goes here?

[Sam McNally, 2014-07-16 09:51:30]

https://codereview.chromium.org/396063006/diff/20001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/396063006/diff/20001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/mojom_java_generator.py:247: if not
isinstance(number, (int, long)):
On 2014/07/16 09:41:36, qsr wrote:
> Should you just raise here? What is the legit case that goes here?

Done.

[qsr, 2014-07-16 09:56:19]

java changes, LGTM

[viettrungluu, 2014-07-17 14:50:25]

LGTM too.

[Sam McNally, 2014-07-17 21:26:19]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:29:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/396063006/80001

[commit-bot: I haz the power, 2014-07-17 22:15:20]

Change committed as 283903