Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: pkg/analysis_server/lib/src/search/search_domain.dart

Issue 396063002: Include 'element' into 'search.findElementReferences' response. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/search/search_domain.dart
diff --git a/pkg/analysis_server/lib/src/search/search_domain.dart b/pkg/analysis_server/lib/src/search/search_domain.dart
index 076ba42fdc275473ecc4d7a6228d6623733d0794..63233e2acb4be2a56b26f5045893b8de8deac462 100644
--- a/pkg/analysis_server/lib/src/search/search_domain.dart
+++ b/pkg/analysis_server/lib/src/search/search_domain.dart
@@ -7,6 +7,7 @@ library search.domain;
import 'dart:async';
import 'package:analysis_server/src/analysis_server.dart';
+import 'package:analysis_server/src/computer/element.dart' as se;
import 'package:analysis_server/src/search/element_references.dart';
import 'package:analysis_server/src/search/search_result.dart';
import 'package:analysis_server/src/constants.dart';
@@ -46,9 +47,19 @@ class SearchDomainHandler implements RequestHandler {
int offset = request.getRequiredParameter(OFFSET).asInt();
bool includePotential =
request.getRequiredParameter(INCLUDE_POTENTIAL).asBool();
+ // prepare elements
+ List<Element> elements = server.getElementsAtOffset(file, offset);
+ elements = elements.map((Element element) {
+ if (element is FieldFormalParameterElement) {
+ return element.field;
+ }
+ if (element is PropertyAccessorElement) {
+ return element.variable;
+ }
+ return element;
+ }).toList();
// schedule search
String searchId = (_nextSearchId++).toString();
- List<Element> elements = server.getElementsAtOffset(file, offset);
elements.forEach((Element element) {
var computer = new ElementReferencesComputer(searchEngine);
var future = computer.compute(element, includePotential);
@@ -63,7 +74,13 @@ class SearchDomainHandler implements RequestHandler {
});
}
// respond
- return new Response(request.id)..setResult(ID, searchId);
+ Response response = new Response(request.id);
+ response.setResult(ID, searchId);
+ if (elements.isNotEmpty) {
+ var serverElement = new se.Element.fromEngine(elements[0]);
+ response.setResult(ELEMENT, serverElement);
+ }
+ return response;
}
Response findMemberDeclarations(Request request) {
« no previous file with comments | « pkg/analysis_server/lib/src/search/element_references.dart ('k') | pkg/analysis_server/test/computer/element_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698