Support "always allow" for runtime script execution

chrome/browser/extensions/permissions_updater.cc

Index: chrome/browser/extensions/permissions_updater.cc
diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc
index 5f2f62981d5889f7db19804d7734561aaaac5b9f..83dc755d478dfe507815bbadd29328e257596002 100644
--- a/chrome/browser/extensions/permissions_updater.cc
+++ b/chrome/browser/extensions/permissions_updater.cc
@@ -67,6 +67,32 @@ scoped_refptr<const PermissionSet> GetBoundedActivePermissions(
   adjusted_active =
       PermissionSet::CreateUnion(required_permissions, adjusted_active);
 
+  // Re-add any active permissions that only match a single origin in order
+  // to persist "always run" script injection hosts.

[not at google - send to devlin, 2014/08/11 22:59:30]

Mention why they were filtered out in the first place.

[gpdavis, 2014/08/12 00:52:05]

Done.

[not at google - send to devlin, 2014/08/12 19:49:26]

The comment still doesn't work for me, but I think it's because this is actually
in the wrong place. See newer comment.

+  URLPatternSet single_origin_explicit;
+  URLPatternSet single_origin_scriptable;
+  for (URLPatternSet::const_iterator iter =
+           active_permissions->explicit_hosts().begin();
+       iter != active_permissions->explicit_hosts().end();
+       ++iter) {
+    if (iter->MatchesSingleOrigin())
+      single_origin_explicit.AddPattern(*iter);
+  }
+  for (URLPatternSet::const_iterator iter =
+           active_permissions->scriptable_hosts().begin();
+       iter != active_permissions->scriptable_hosts().end();
+       ++iter) {
+    if (iter->MatchesSingleOrigin())
+      single_origin_scriptable.AddPattern(*iter);
+  }
+

[not at google - send to devlin, 2014/08/11 22:59:30]

you could write this much more concisely if you had a FilterSingleOriginPatterns
method, such that you can call

adjusted_active = PermissionSet::CreateUnion(
    adjusted_active,
    new PermissionSet(APIPermissionSet(),
                      ManifestPermissionSet(),
                     
FilterSingleOriginPermissions(active_permissions->explicit_hosts()),
                     
FilterSingleOriginPermissions(active_permissions->scriptable_hosts());

formatting modulo git-cl format.

[gpdavis, 2014/08/12 00:52:05]

Done.

+  adjusted_active = PermissionSet::CreateUnion(
+      adjusted_active,
+      new PermissionSet(APIPermissionSet(),
+                        ManifestPermissionSet(),
+                        single_origin_explicit,
+                        single_origin_scriptable));
+
   return adjusted_active;
 }