Support "always allow" for runtime script execution

extensions/common/url_pattern.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/url_pattern.h"
 
 #include <ostream>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
@@ skipping 448 matching lines @@
   // unrecognized, or the length of the recognized TLD.
   registry_length = net::registry_controlled_domains::GetRegistryLength(
       base::StringPrintf("foo.%s", host_.c_str()),
       net::registry_controlled_domains::EXCLUDE_UNKNOWN_REGISTRIES,
       net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);
   // If we recognized this TLD, then this is a pattern like *.com, and it
   // should imply all hosts. Otherwise, this doesn't imply all hosts.
   return registry_length > 0;
 }
 
+bool URLPattern::MatchesSingleOrigin() const {
+  return scheme_ != "*" && !ImpliesAllHosts() && !match_subdomains_;

[not at google - send to devlin, 2014/08/12 19:49:27]

you should check the port here as well.

and as a nit, it would be nice to arrange the checks in the order that they
appear, so like

return !ImpliesAllHosts() && scheme_ != "*" && port_ != "*" &&
!match_subdomains_;

[gpdavis, 2014/08/12 21:19:55]

When I test this out (logging the visible url's port in the
ActiveScriptController before its origin is added) and hit "always run" on the
google homepage, the port is blank, so it gets added as "*" when it's parsed in
AddOrigin.

How should the port be dealt with?

[not at google - send to devlin, 2014/08/12 23:13:18]

Ah ok. Yeah, forget about port, whatever. Just comment that it's not
interesting.

[gpdavis, 2014/08/13 00:08:24]

Done.

+}
+
 bool URLPattern::MatchesPath(const std::string& test) const {
   // Make the behaviour of OverlapsWith consistent with MatchesURL, which is
   // need to match hosted apps on e.g. 'google.com' also run on 'google.com/'.
   if (test + "/*" == path_escaped_)
     return true;
 
   return MatchPattern(test, path_escaped_);
 }
 
 const std::string& URLPattern::GetAsString() const {
@@ skipping 120 matching lines @@
   }
 
   return result;
 }
 
 // static
 const char* URLPattern::GetParseResultString(
     URLPattern::ParseResult parse_result) {
   return kParseResultMessages[parse_result];
 }