Support "always allow" for runtime script execution

chrome/browser/extensions/active_tab_permission_granter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/active_tab_permission_granter.h"
 
 #include "chrome/browser/extensions/active_script_controller.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
@@ skipping 29 matching lines @@
   APIPermissionSet new_apis;
   URLPatternSet new_hosts;
 
   const PermissionsData* permissions_data = extension->permissions_data();
 
   // If the extension requested all-hosts but has had it withheld, we grant it
   // active tab-style permissions, even if it doesn't have the activeTab
   // permission in the manifest.
   if (permissions_data->HasAPIPermission(APIPermission::kActiveTab) ||
       permissions_data->HasWithheldImpliedAllHosts()) {
-    URLPattern pattern(UserScript::ValidUserScriptSchemes());
-    // Pattern parsing could fail if this is an unsupported URL e.g. chrome://.
-    if (pattern.Parse(web_contents()->GetURL().spec()) ==
-            URLPattern::PARSE_SUCCESS) {
-      new_hosts.AddPattern(pattern);
-    }
+    // Origin adding could fail if this is an unsupported URL e.g. chrome://.

[not at google - send to devlin, 2014/08/12 19:49:27]

comment isn't for here (it should be inside the AddOrigin call).

[gpdavis, 2014/08/12 21:19:55]

Done.

+    new_hosts.AddOrigin(UserScript::ValidUserScriptSchemes(),
+                        web_contents()->GetURL().GetOrigin());

[not at google - send to devlin, 2014/08/12 19:49:27]

cleanup: use GetVisibleURL() here.

[gpdavis, 2014/08/12 21:19:54]

Done.

     new_apis.insert(APIPermission::kTab);
   }
 
   if (permissions_data->HasAPIPermission(APIPermission::kTabCapture))
     new_apis.insert(APIPermission::kTabCaptureForTab);
 
   if (!new_apis.empty() || !new_hosts.is_empty()) {
     granted_extensions_.Insert(extension);
     scoped_refptr<const PermissionSet> new_permissions =
         new PermissionSet(new_apis, ManifestPermissionSet(),
@@ skipping 50 matching lines @@
        it != granted_extensions_.end(); ++it) {
     it->get()->permissions_data()->ClearTabSpecificPermissions(tab_id_);
     extension_ids.push_back((*it)->id());
   }
 
   Send(new ExtensionMsg_ClearTabSpecificPermissions(tab_id_, extension_ids));
   granted_extensions_.Clear();
 }
 
 }  // namespace extensions