Issue 396023003: Change SPACEPARITY in the Windows serial api implementation to ODDPARITY.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396023003: Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (Closed)

Created:
6 years, 5 months ago by Sam McNally

Modified:
6 years, 5 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	device/serial/serial_io_handler_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/396023003/1

6 years, 5 months ago (2014-07-17 21:29:23 UTC) #4

gab

6 years, 5 months ago (2014-07-18 14:13:16 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/399353007/ by gab@chromium.org.

The reason for reverting is: Very speculative revert for current XP bots
failures (all 3 bots are failing with obscure errors and this is our last
suspect in the list...).

I'll reland if that's not it.

Thanks for your understanding!.

Expand Messages | Collapse Messages