Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 396003002: Fix buffer reuse bug in SSLServerSocket tests. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix buffer reuse bug in SSLServerSocket tests. Write would return synchronously but continue to retain the buffer. BUG=380340, 381147 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283454

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M net/socket/ssl_server_socket_unittest.cc View 4 chunks +8 lines, -8 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
davidben
6 years, 5 months ago (2014-07-15 19:49:37 UTC) #1
Ryan Sleevi
Good catch! LGTM! https://codereview.chromium.org/396003002/diff/1/net/socket/ssl_server_socket_unittest.cc File net/socket/ssl_server_socket_unittest.cc (right): https://codereview.chromium.org/396003002/diff/1/net/socket/ssl_server_socket_unittest.cc#newcode73 net/socket/ssl_server_socket_unittest.cc:73: return net::ERR_IO_PENDING; I'll send you a ...
6 years, 5 months ago (2014-07-15 20:09:53 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-15 20:58:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/396003002/1
6 years, 5 months ago (2014-07-15 21:01:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 03:56:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 04:26:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171023)
6 years, 5 months ago (2014-07-16 04:26:54 UTC) #7
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-16 16:17:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/396003002/1
6 years, 5 months ago (2014-07-16 16:20:43 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:40:50 UTC) #10
Message was sent while issue was closed.
Change committed as 283454

Powered by Google App Engine
This is Rietveld 408576698