Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 395993002: Mojo: get .so from PRODUCT_DIR for packaged apps (Closed)

Created:
6 years, 5 months ago by DaveMoore
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: get .so from PRODUCT_DIR for packaged apps. This changed when we made them be LOADABLE_MODULEs BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/build/package_app.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
DaveMoore
6 years, 5 months ago (2014-07-15 19:42:27 UTC) #1
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-15 21:53:51 UTC) #2
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 5 months ago (2014-07-15 22:25:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/395993002/1
6 years, 5 months ago (2014-07-15 22:27:29 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:55:30 UTC) #5
Message was sent while issue was closed.
Change committed as 283458

Powered by Google App Engine
This is Rietveld 408576698