Issue 395963002: Do not invoke SetNaClArch if the hotword extension is new enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395963002: Do not invoke SetNaClArch if the hotword extension is new enough. (Closed)

Created:
6 years, 5 months ago by Jun Mukai

Modified:
6 years, 5 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not invoke SetNaClArch if the hotword extension is new enough. This would be essentially harmless, but setting 'nacl arch' in StartPageHandler means allowing embed of the hotword plugin, which consumes memory and CPU. Because it communicates with the hotword extension directly, this plugin is unused at all. BUG=393321 R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283745

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	chrome/browser/ui/webui/app_list/start_page_handler.cc	View		1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/395963002/1

6 years, 5 months ago (2014-07-16 18:50:52 UTC) #4

Message was sent while issue was closed.

Change committed as 283745

Expand Messages | Collapse Messages