runtime/vm/flow_graph.cc - Issue 395943003: Support allocation sinking for compound objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph.cc

Issue 395943003: Support allocation sinking for compound objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: improve tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph.cc

diff --git a/runtime/vm/flow_graph.cc b/runtime/vm/flow_graph.cc

index d2d0d117cc1c959e1673e3363fc4f5094f0e5fb2..3c710e57b1912bbfbc46836442fc547151866d21 100644

--- a/runtime/vm/flow_graph.cc

+++ b/runtime/vm/flow_graph.cc

@@ -193,7 +193,9 @@ static void VerifyUseListsInInstruction(Instruction* instr) {

for (intptr_t i = 0; i < instr->InputCount(); ++i) {

Value* use = instr->InputAt(i);

ASSERT(use->definition() != NULL);

- ASSERT((use->definition() != instr) || use->definition()->IsPhi());

+ ASSERT((use->definition() != instr) ||

+ use->definition()->IsPhi() ||

+ use->definition()->IsMaterializeObject());

ASSERT(use->instruction() == instr);

ASSERT(use->use_index() == i);

ASSERT(!FLAG_verify_compiler ||

« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | runtime/vm/flow_graph_allocator.cc » ('j') | no next file with comments »