Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: runtime/vm/deferred_objects.h

Issue 395943003: Support allocation sinking for compound objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: improve tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/deferred_objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/deferred_objects.h
diff --git a/runtime/vm/deferred_objects.h b/runtime/vm/deferred_objects.h
index 9619d16e5ab1be72e8dc7186ba3ad7da404a876d..cfb8d94243693ced65233ab3302e412769bcbd4a 100644
--- a/runtime/vm/deferred_objects.h
+++ b/runtime/vm/deferred_objects.h
@@ -157,6 +157,9 @@ class DeferredObject {
RawInstance* object();
+ // Fill object with actual field values.
+ void Fill();
+
private:
enum {
kClassIndex = 0,
@@ -169,10 +172,11 @@ class DeferredObject {
kFieldEntrySize,
};
- // Materializes the object. Returns amount of values that were consumed
- // and should be removed from the expression stack at the very end of
- // deoptimization.
- void Materialize();
+ // Allocate the object but keep its fields null-initialized. Actual field
+ // values will be filled later by the Fill method. This separation between
+ // allocation and filling is needed because dematerialized objects form
+ // a graph which can contain cycles.
+ void Create();
RawObject* GetClass() const {
return args_[kClassIndex];
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/deferred_objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698