Support allocation sinking for compound objects.

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 
 #include "vm/ast_printer.h"
 #include "vm/block_scheduler.h"
@@ skipping 461 matching lines @@
         TryCatchAnalyzer::Optimize(flow_graph);
 
         // Detach environments from the instructions that can't deoptimize.
         // Do it before we attempt to perform allocation sinking to minimize
         // amount of materializations it has to perform.
         optimizer.EliminateEnvironments();
 
         DeadCodeElimination::EliminateDeadPhis(flow_graph);
         DEBUG_ASSERT(flow_graph->VerifyUseLists());
 
+        if (optimizer.Canonicalize()) {
+          optimizer.Canonicalize();

[srdjan, 2014/07/17 23:08:14]

Why another canonicalization?

[Vyacheslav Egorov (Google), 2014/07/18 11:25:08]

When writing tests I noticed that we often arrive to the following IR right
before allocation sinking:

v1 <- AllocateObject(...)
...
CheckClass(v1, ...)

I run one more canonicalization to remove this CheckClass instruction.

Ideally our Canonicalize just needs to run every time we rewire uses, otherwise
we constantly miss optimization opportunities.

+        }
+
         // Attempt to sink allocations of temporary non-escaping objects to
         // the deoptimization path.
         AllocationSinking* sinking = NULL;
         if (FLAG_allocation_sinking &&
             (flow_graph->graph_entry()->SuccessorCount()  == 1)) {
           // TODO(fschneider): Support allocation sinking with try-catch.
           sinking = new AllocationSinking(flow_graph);
           sinking->Optimize();
         }
         DEBUG_ASSERT(flow_graph->VerifyUseLists());
@@ skipping 477 matching lines @@
     const Object& result =
       Object::Handle(isolate->object_store()->sticky_error());
     isolate->object_store()->clear_sticky_error();
     return result.raw();
   }
   UNREACHABLE();
   return Object::null();
 }
 
 }  // namespace dart