Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 395943002: Remove media::AudioRendererImpl::now_cb_ and clean up tests (round 2). (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove media::AudioRendererImpl::now_cb_ and clean up tests (round 2). It's no longer needed as of r282376. BUG=370634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283443

Patch Set 1 #

Patch Set 2 : MSVC fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -161 lines) Patch
M media/filters/audio_renderer_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M media/filters/audio_renderer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/audio_renderer_impl_unittest.cc View 1 24 chunks +58 lines, -151 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scherkus (not reviewing)
rileya: can you take another look? I had to revert since MSVC executed things differently ...
6 years, 5 months ago (2014-07-15 17:57:51 UTC) #1
rileya (GONE FROM CHROMIUM)
On 2014/07/15 17:57:51, scherkus wrote: > rileya: can you take another look? > > I ...
6 years, 5 months ago (2014-07-15 18:31:19 UTC) #2
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-15 18:54:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/395943002/10001
6 years, 5 months ago (2014-07-15 18:57:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 02:01:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 04:53:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39275)
6 years, 5 months ago (2014-07-16 04:53:50 UTC) #7
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-16 16:22:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/395943002/10001
6 years, 5 months ago (2014-07-16 16:24:12 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:29:09 UTC) #10
Message was sent while issue was closed.
Change committed as 283443

Powered by Google App Engine
This is Rietveld 408576698