Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 395933002: Use Dequeue::removeLast() in StyleResolver::addToStyleSharingList() (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Use Dequeue::removeLast() in StyleResolver::addToStyleSharingList() Use Dequeue::removeLast() in StyleResolver::addToStyleSharingList() instead of Dequeue::remove(--end()) to remove the last element in the Dequeue. This increases the code readability a bit and removeLast() implementation is a bit simpler. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 5 months ago (2014-07-15 18:38:56 UTC) #1
esprehn
lgtm
6 years, 5 months ago (2014-07-15 19:45:58 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-15 19:46:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/395933002/1
6 years, 5 months ago (2014-07-15 19:47:08 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 20:26:05 UTC) #5
Message was sent while issue was closed.
Change committed as 178200

Powered by Google App Engine
This is Rietveld 408576698