Issue 39593002: Revert "Make Array.prototype.pop throw if the last element is not configurable."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39593002: Revert "Make Array.prototype.pop throw if the last element is not configurable." (Closed)

Created:
7 years, 2 months ago by Yang

Modified:
7 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Make Array.prototype.pop throw if the last element is not configurable." This reverts commit r17346. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17360

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -35 lines)			Patch
M	src/array.js	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/mjsunit/regress/regress-array-pop-nonconfigurable.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	tools/presubmit.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

7 years, 2 months ago (2013-10-24 07:48:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17360 (presubmit successful).