Issue 395913003: Add server_attachment_metadata field to EntryKernel and sync database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395913003: Add server_attachment_metadata field to EntryKernel and sync database. (Closed)

Created:
6 years, 5 months ago by maniscalco

Modified:
6 years, 5 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add server_attachment_metadata field to EntryKernel and sync database. The server_attachment_metadata field is where attachment metadata received from the sync server is stored during the "process updates" part of the sync cycle. A subsequent CL will make use of this new field. BUG=394023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283355

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -7 lines)			Patch
M	sync/syncable/directory_backing_store.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/syncable/directory_backing_store.cc	View	3 chunks	+19 lines, -1 line	0 comments	Download
M	sync/syncable/directory_backing_store_unittest.cc	View	15 chunks	+153 lines, -4 lines	0 comments	Download
M	sync/syncable/entry.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sync/syncable/entry_kernel.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/syncable/syncable_columns.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sync/syncable/syncable_enum_conversions.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sync/test/test_directory_backing_store.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

maniscalco

Hi Richard, would you please review this change? This is the DB change pulled out ...

6 years, 5 months ago (2014-07-15 19:51:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/395913003/1

6 years, 5 months ago (2014-07-15 20:20:35 UTC) #4

Message was sent while issue was closed.

Change committed as 283355

Expand Messages | Collapse Messages