Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/shell/renderer/test_runner/notification_presenter.cc

Issue 395883002: Support layout testing Web Notifications from Document and Worker contexts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/notification_presenter.cc
diff --git a/content/shell/renderer/test_runner/notification_presenter.cc b/content/shell/renderer/test_runner/notification_presenter.cc
index 98c5aea8d6330597cfb843357f111e970fd029b4..4c4960574335d2b881f9b5ffd303f0064a05a0d9 100644
--- a/content/shell/renderer/test_runner/notification_presenter.cc
+++ b/content/shell/renderer/test_runner/notification_presenter.cc
@@ -4,6 +4,8 @@
#include "content/shell/renderer/test_runner/notification_presenter.h"
+#include "base/logging.h"
+#include "content/common/desktop_notification_messages.h"
#include "content/shell/renderer/test_runner/WebTestDelegate.h"
#include "third_party/WebKit/public/platform/Platform.h"
#include "third_party/WebKit/public/platform/WebString.h"
@@ -37,11 +39,6 @@ NotificationPresenter::NotificationPresenter() : delegate_(0) {}
NotificationPresenter::~NotificationPresenter() {}
-void NotificationPresenter::GrantPermission(const std::string& origin,
- bool permission_granted) {
- known_origins_[origin] = permission_granted;
-}
-
bool NotificationPresenter::SimulateClick(const std::string& title) {
ActiveNotificationMap::iterator iter = active_notifications_.find(title);
if (iter == active_notifications_.end())
@@ -61,7 +58,6 @@ void NotificationPresenter::Reset() {
cancel(notification);
}
- known_origins_.clear();
replacements_.clear();
}
@@ -130,25 +126,14 @@ void NotificationPresenter::objectDestroyed(
WebNotificationPresenter::Permission NotificationPresenter::checkPermission(
const WebSecurityOrigin& security_origin) {
- const std::string origin = security_origin.toString().utf8();
- const KnownOriginMap::iterator it = known_origins_.find(origin);
- if (it == known_origins_.end())
- return WebNotificationPresenter::PermissionNotAllowed;
-
- // Values in |known_origins_| indicate whether permission has been granted.
- if (it->second)
- return WebNotificationPresenter::PermissionAllowed;
-
- return WebNotificationPresenter::PermissionDenied;
+ return delegate_->checkWebNotificationPermission(
+ GURL(security_origin.toString()));
}
void NotificationPresenter::requestPermission(
const WebSecurityOrigin& security_origin,
WebNotificationPermissionCallback* callback) {
- std::string origin = security_origin.toString().utf8();
- delegate_->printMessage("DESKTOP NOTIFICATION PERMISSION REQUESTED: " +
- origin + "\n");
- callback->permissionRequestComplete();
+ NOTREACHED();
}
} // namespace content
« no previous file with comments | « content/shell/renderer/test_runner/notification_presenter.h ('k') | content/shell/renderer/test_runner/test_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698