Support layout testing Web Notifications from Document and Worker contexts.

Support layout testing Web Notifications from Document and Worker contexts.

Web Notifications are currently exercised by providing a custom notification
presenter as the TestRunner, but this solution isn't sufficient anymore now
that they will be available to Web Workers as well.

Instead, implement a mocked Notification Manager which is only available
in content_shell when running in layout test mode. This manager means we can
exercise the complete code-paths for both the Document and Worker scenarios,
yet still provide for mocked functionality available to both.

Note that this code isn't being used yet, pending on Blink switching over
to the new Web Notification permission path, which should be shortly after
this patch lands.

BUG=392187
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286513

[Peter Beverloo, 2014-07-15 16:28:27]

This provides testing infrastructure for (and is depending on):
  https://codereview.chromium.org/381633005/

After that (and this patch) lands, we can enable the new path in Blink:
  https://codereview.chromium.org/393863002/

https://codereview.chromium.org/395883002/diff/1/content/shell/common/shell_m...
File content/shell/common/shell_messages.h (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/common/shell_m...
content/shell/common/shell_messages.h:101:
IPC_SYNC_MESSAGE_ROUTED1_1(ShellViewHostMsg_CheckWebNotificationPermission,
Note that this IPC will go away when the NotificationPresenter moves off
WebFrame, at which time the entire NotificationPresenter for TestRunner will go
away as well. Instead, there will be an
ShellViewHostMsg_SimulateWebNotificationClick(string title) IPC.

https://codereview.chromium.org/395883002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/WebTestDelegate.h (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/WebTestDelegate.h:123: virtual
blink::WebNotificationPresenter::Permission
Note that blink::WebNotificationPresenter::Permission will be replaced with
blink::WebNotificationPermission, but it will be a bit tricky to replace this
all throughout the source at once.

[jochen (gone - plz use gerrit), 2014-07-17 09:29:45]

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
File content/shell/browser/shell_content_browser_client.cc (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_content_browser_client.cc:142:
ShellContentBrowserClient::GetShellNotificationManager() {
add a DCHECK() that we're on the IO thread?

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_content_browser_client.cc:294:
manager->RequestPermission(source_origin, callback);
invoke the callback with some default if no manager is present?

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
File content/shell/browser/shell_notification_manager.cc (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_notification_manager.cc:25: // TODO(peter): The
request's result should be passed to |callback|.
should be easy to implement, no?

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
File content/shell/browser/shell_notification_manager.h (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_notification_manager.h:42: };
disallow copy/assign

[Peter Beverloo, 2014-07-17 12:22:53]

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
File content/shell/browser/shell_content_browser_client.cc (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_content_browser_client.cc:142:
ShellContentBrowserClient::GetShellNotificationManager() {
On 2014/07/17 09:29:45, jochen wrote:
> add a DCHECK() that we're on the IO thread?

Ugh, fantastic. CBC::RequestDesktopNotificationPermission is expected to be
called on the IO thread, whereas CBC::CheckDesktopNotificationPermission is
expected to be called on the UI thread. Thanks for pointing this out. I'll jump
to IO for Request*.

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_content_browser_client.cc:294:
manager->RequestPermission(source_origin, callback);
On 2014/07/17 09:29:45, jochen wrote:
> invoke the callback with some default if no manager is present?

Done.

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
File content/shell/browser/shell_notification_manager.cc (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_notification_manager.cc:25: // TODO(peter): The
request's result should be passed to |callback|.
On 2014/07/17 09:29:45, jochen wrote:
> should be easy to implement, no?

It requires changing the chrome/ implementation of CBC as well, which I was
hoping to avoid in the other patch. I'll include this in
https://codereview.chromium.org/381633005/.

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
File content/shell/browser/shell_notification_manager.h (right):

https://codereview.chromium.org/395883002/diff/1/content/shell/browser/shell_...
content/shell/browser/shell_notification_manager.h:42: };
On 2014/07/17 09:29:45, jochen wrote:
> disallow copy/assign

Done.

[jochen (gone - plz use gerrit), 2014-07-17 12:38:38]

lgtm

[Peter Beverloo, 2014-07-30 11:23:59]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-07-30 11:26:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peter@chromium.org/395883002/100001

[commit-bot: I haz the power, 2014-07-30 14:25:36]

Change committed as 286513