Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 395843002: Oilpan: make ViewportAnchor fully stack allocated. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: make ViewportAnchor fully stack allocated. Mark this class with STACK_ALLOCATED() and convert its on-heap references into Members as a result. R=ager@chromium.org,haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/web/ViewportAnchor.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-15 13:37:16 UTC) #1
Mads Ager (chromium)
lgtm
6 years, 5 months ago (2014-07-15 14:04:24 UTC) #2
haraken
LGTM
6 years, 5 months ago (2014-07-15 14:06:57 UTC) #3
sof
tkent@: have a look at Source/web/, please? thanks.
6 years, 5 months ago (2014-07-16 05:05:32 UTC) #4
tkent
lgtm
6 years, 5 months ago (2014-07-16 05:15:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/395843002/1
6 years, 5 months ago (2014-07-16 05:15:44 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 06:17:17 UTC) #7
Message was sent while issue was closed.
Change committed as 178250

Powered by Google App Engine
This is Rietveld 408576698