Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 395833002: [Chromium] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd… (Closed)

Created:
6 years, 5 months ago by vivekg_samsung
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Chromium] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py This is chromium side changes required for moving XMLViewer resources in grd file here [1] [1] https://codereview.chromium.org/391963002/ BUG=312586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
vivekg
PTAL, thank you!
6 years, 5 months ago (2014-07-15 12:21:03 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-15 19:38:58 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-16 08:27:41 UTC) #3
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-18 05:40:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/395833002/1
6 years, 5 months ago (2014-07-18 05:42:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 07:18:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 07:24:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/builds/4445)
6 years, 5 months ago (2014-07-18 07:24:08 UTC) #8
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-18 14:09:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/395833002/1
6 years, 5 months ago (2014-07-18 14:10:31 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 18:37:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 19:02:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172599)
6 years, 5 months ago (2014-07-18 19:02:33 UTC) #13
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-19 01:15:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/395833002/1
6 years, 5 months ago (2014-07-19 01:16:04 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 03:15:33 UTC) #16
Message was sent while issue was closed.
Change committed as 284302

Powered by Google App Engine
This is Rietveld 408576698