Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 395793003: [DevTools] Fix undocked DevToolsWindow closing. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix undocked DevToolsWindow closing. Test will follow in next patch, as it requires testing code refactoring. BUG=393566, 393855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-15 10:43:17 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-15 10:49:27 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-15 11:08:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/395793003/1
6 years, 5 months ago (2014-07-15 11:11:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 20:31:57 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 04:58:25 UTC) #6
Message was sent while issue was closed.
Change committed as 283345

Powered by Google App Engine
This is Rietveld 408576698