Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 395763002: [Mac] Temporarily disable timer coalescing (Closed)

Created:
6 years, 5 months ago by jeremy
Modified:
6 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, tonyg
Project:
chromium
Visibility:
Public.

Description

[Mac] Temporarily disable timer coalescing on Mac. In the interest of conserving power, several incremental changes to timer slack have been committed over the last few weeks. This CL disables those changes so we can get some numbers for the combined effect in terms of power usage and idle wakeup numbers. This needs to be checked in because we can only get a good comparative measure for this when run on the bots in a controlled environment. BUG=356804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283311

Patch Set 1 #

Patch Set 2 : Take 2 #

Total comments: 1

Patch Set 3 : #if 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/message_loop/message_pump_mac.mm View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jeremy
6 years, 5 months ago (2014-07-15 11:01:26 UTC) #1
Mark Mentovai
https://codereview.chromium.org/395763002/diff/20001/base/message_loop/message_pump_mac.mm File base/message_loop/message_pump_mac.mm (left): https://codereview.chromium.org/395763002/diff/20001/base/message_loop/message_pump_mac.mm#oldcode74 base/message_loop/message_pump_mac.mm:74: void SetTimerTolerance(CFRunLoopTimerRef timer, CFTimeInterval tolerance) { This will be ...
6 years, 5 months ago (2014-07-15 13:50:35 UTC) #2
jeremy
Makes sense, done.
6 years, 5 months ago (2014-07-15 13:58:22 UTC) #3
Mark Mentovai
LGTM
6 years, 5 months ago (2014-07-15 14:03:35 UTC) #4
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 5 months ago (2014-07-15 14:04:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/395763002/40001
6 years, 5 months ago (2014-07-15 14:06:53 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 00:59:34 UTC) #7
Message was sent while issue was closed.
Change committed as 283311

Powered by Google App Engine
This is Rietveld 408576698