Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 395753002: Added NULL check in WebContentsViewAura when commencing a drag. (Closed)

Created:
6 years, 5 months ago by Matt Giuca
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Marshall, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Added NULL check in WebContentsViewAura when commencing a drag. This prevents a crash if a WebContents has no WebContentsDelegate. BUG=391202 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283682

Patch Set 1 #

Patch Set 2 : Avoid making a temporary variable (consistent with other uses). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Giuca
Looks like everywhere else in this file null-checks the GetDelegate(), so it should be safe ...
6 years, 5 months ago (2014-07-15 09:07:16 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-16 16:55:37 UTC) #2
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 5 months ago (2014-07-17 01:31:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/395753002/20001
6 years, 5 months ago (2014-07-17 01:32:00 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 07:14:30 UTC) #5
Message was sent while issue was closed.
Change committed as 283682

Powered by Google App Engine
This is Rietveld 408576698