Rebaseline virtual/android/fullscreen/parent-flow-inline-with-block-child.html

Rebaseline virtual/android/fullscreen/parent-flow-inline-with-block-child.html

This test has been marked as [ Failure ] for a long time. As a matter of
policy, if a test output is undesirable we should open a bug for it and expect
the undesirable result, instead of marking the failure in TestExpectations and
expecting the desirable result.

Actually, the non-virtual test suite already expects the undesirable output.
I don't remember why virtual/android is expecting the desirable one.
I suspect it slipped in the many reverts/retries of crbug.com/240576.

Anyway, the main point of the test was that we don't crash.

BUG=393886
R=philipj@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178159

[falken, 2014-07-15 08:35:17]

Philip, could you please review?

This patch was created with:
Tools/Scripts/webkit-patch rebaseline-expectations

[philipj_slow, 2014-07-15 08:56:10]

LGTM, but why is both an -expected.png and -expected.txt needed?

[philipj_slow, 2014-07-15 08:59:56]

FWIW, when I remove
LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.png the test
still passes on Linux Debug. Removing the -expected.txt instead yields this:
[48/54] fullscreen/parent-flow-inline-with-block-child.html failed unexpectedly
(-expected.txt was missing)

[falken, 2014-07-15 09:04:16]

On 2014/07/15 08:56:10, philipj wrote:
> LGTM, but why is both an -expected.png and -expected.txt needed?

Thanks! I think WebKit pixel tests have long had both png and txt expectations.

[philipj_slow, 2014-07-15 09:32:21]

On 2014/07/15 09:04:16, falken wrote:
> On 2014/07/15 08:56:10, philipj wrote:
> > LGTM, but why is both an -expected.png and -expected.txt needed?
> 
> Thanks! I think WebKit pixel tests have long had both png and txt
expectations.

Right you are, I've been assuming it's one or the other without paying
attention. There are exceptions where only -expected.png is there, but they're
very few outside of platform/

[falken, 2014-07-15 10:08:54]

Committed patchset #2 manually as r178159 (presubmit successful).