src/objects-visiting-inl.h - Issue 395713002: Allow embedding of ConsString objects into code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-visiting-inl.h

Issue 395713002: Allow embedding of ConsString objects into code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed moar comments by Yang Guo. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-visiting-inl.h

diff --git a/src/objects-visiting-inl.h b/src/objects-visiting-inl.h

index 887a3de868f69bd650e7ad11ac605117203b0d38..f7341c98e3e7ae869c0d67bf049b35f8ea3511df 100644

--- a/src/objects-visiting-inl.h

+++ b/src/objects-visiting-inl.h

@@ -237,7 +237,6 @@ template<typename StaticVisitor>

void StaticMarkingVisitor<StaticVisitor>::VisitEmbeddedPointer(

Heap* heap, RelocInfo* rinfo) {

ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT);

- ASSERT(!rinfo->target_object()->IsConsString());

HeapObject* object = HeapObject::cast(rinfo->target_object());

heap->mark_compact_collector()->RecordRelocSlot(rinfo, object);

// TODO(ulan): It could be better to record slots only for strongly embedded

« no previous file with comments | « src/objects.cc ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »