src/ic.cc - Issue 395713002: Allow embedding of ConsString objects into code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 395713002: Allow embedding of ConsString objects into code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed moar comments by Yang Guo. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 2b9e29c3c1bf78b8abab0cf23c686f67ffaf5e48..ac442fbcc3f70813e6a6d1bdf53e593684a32da5 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -992,9 +992,6 @@ Handle<Code> LoadIC::CompileHandler(LookupResult* lookup,

}

case CONSTANT: {

Handle<Object> constant(lookup->GetConstant(), isolate());

- // TODO(2803): Don't compute a stub for cons strings because they cannot

- // be embedded into code.

- if (constant->IsConsString()) break;

return compiler.CompileLoadConstant(type, holder, name, constant);

}

case NORMAL:

« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »