src/arm64/assembler-arm64-inl.h - Issue 395713002: Allow embedding of ConsString objects into code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/assembler-arm64-inl.h

Issue 395713002: Allow embedding of ConsString objects into code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Yang Guo. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/assembler-arm64-inl.h

diff --git a/src/arm64/assembler-arm64-inl.h b/src/arm64/assembler-arm64-inl.h

index a0bcb77e6b5cd7f0eb8bdadfe17119ba01728397..1454adf44c9c947f81117137f90a2598333dde64 100644

--- a/src/arm64/assembler-arm64-inl.h

+++ b/src/arm64/assembler-arm64-inl.h

@@ -716,7 +716,6 @@ void RelocInfo::set_target_object(Object* target,

WriteBarrierMode write_barrier_mode,

ICacheFlushMode icache_flush_mode) {

ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);

- ASSERT(!target->IsConsString());

Assembler::set_target_address_at(pc_, host_,

reinterpret_cast<Address>(target),

icache_flush_mode);