Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/assembler-mips-inl.h

Issue 395713002: Allow embedding of ConsString objects into code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed moar comments by Yang Guo. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 1994-2006 Sun Microsystems Inc. 2 // Copyright (c) 1994-2006 Sun Microsystems Inc.
3 // All Rights Reserved. 3 // All Rights Reserved.
4 // 4 //
5 // Redistribution and use in source and binary forms, with or without 5 // Redistribution and use in source and binary forms, with or without
6 // modification, are permitted provided that the following conditions are 6 // modification, are permitted provided that the following conditions are
7 // met: 7 // met:
8 // 8 //
9 // - Redistributions of source code must retain the above copyright notice, 9 // - Redistributions of source code must retain the above copyright notice,
10 // this list of conditions and the following disclaimer. 10 // this list of conditions and the following disclaimer.
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 200 ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
201 return Handle<Object>(reinterpret_cast<Object**>( 201 return Handle<Object>(reinterpret_cast<Object**>(
202 Assembler::target_address_at(pc_, host_))); 202 Assembler::target_address_at(pc_, host_)));
203 } 203 }
204 204
205 205
206 void RelocInfo::set_target_object(Object* target, 206 void RelocInfo::set_target_object(Object* target,
207 WriteBarrierMode write_barrier_mode, 207 WriteBarrierMode write_barrier_mode,
208 ICacheFlushMode icache_flush_mode) { 208 ICacheFlushMode icache_flush_mode) {
209 ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 209 ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
210 ASSERT(!target->IsConsString());
211 Assembler::set_target_address_at(pc_, host_, 210 Assembler::set_target_address_at(pc_, host_,
212 reinterpret_cast<Address>(target), 211 reinterpret_cast<Address>(target),
213 icache_flush_mode); 212 icache_flush_mode);
214 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 213 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
215 host() != NULL && 214 host() != NULL &&
216 target->IsHeapObject()) { 215 target->IsHeapObject()) {
217 host()->GetHeap()->incremental_marking()->RecordWrite( 216 host()->GetHeap()->incremental_marking()->RecordWrite(
218 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 217 host(), &Memory::Object_at(pc_), HeapObject::cast(target));
219 } 218 }
220 } 219 }
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 } 436 }
438 *reinterpret_cast<Instr*>(pc_) = x; 437 *reinterpret_cast<Instr*>(pc_) = x;
439 pc_ += kInstrSize; 438 pc_ += kInstrSize;
440 CheckTrampolinePoolQuick(); 439 CheckTrampolinePoolQuick();
441 } 440 }
442 441
443 442
444 } } // namespace v8::internal 443 } } // namespace v8::internal
445 444
446 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_ 445 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698