Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 395653005: Stop app list folder animation from hiding item text label. (Closed)

Created:
6 years, 5 months ago by calamity
Modified:
6 years, 5 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Stop app list folder animation from hiding item text label. This CL fixes an issue where the app list folder animation would hide the item label for its animation, causing the text to pop in at the end of animation. This is fixed by only hiding the icon rather than the entire AppListItemView during the animation. BUG=393207 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/app_list/views/app_list_item_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
calamity
6 years, 5 months ago (2014-07-15 01:42:50 UTC) #1
Matt Giuca
lgtm
6 years, 5 months ago (2014-07-15 01:49:24 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 5 months ago (2014-07-15 01:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/395653005/1
6 years, 5 months ago (2014-07-15 01:50:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 13:56:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 18:09:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/builds/3598)
6 years, 5 months ago (2014-07-15 18:09:43 UTC) #7
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 5 months ago (2014-07-16 02:19:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/395653005/1
6 years, 5 months ago (2014-07-16 02:21:16 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 04:26:48 UTC) #10
Message was sent while issue was closed.
Change committed as 283331

Powered by Google App Engine
This is Rietveld 408576698