Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 395653002: Renamed Permissions section in App Info dialog (Closed)

Created:
6 years, 5 months ago by sashab
Modified:
6 years, 5 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Renamed Permissions section in App Info dialog The permissions section in the App Info dialog originally started with 'It can'. Changed it to start with 'Permissions', so it is consistent with the other dialog headings. BUG=386871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sashab
6 years, 5 months ago (2014-07-15 00:21:17 UTC) #1
Matt Giuca
lgtm
6 years, 5 months ago (2014-07-15 00:22:52 UTC) #2
sashab
The CQ bit was checked by sashab@chromium.org
6 years, 5 months ago (2014-07-15 00:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sashab@chromium.org/395653002/1
6 years, 5 months ago (2014-07-15 00:24:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 16:44:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 17:43:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/38941)
6 years, 5 months ago (2014-07-15 17:43:51 UTC) #7
sashab
The CQ bit was checked by sashab@chromium.org
6 years, 5 months ago (2014-07-17 00:38:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sashab@chromium.org/395653002/1
6 years, 5 months ago (2014-07-17 00:41:24 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 03:28:32 UTC) #10
Message was sent while issue was closed.
Change committed as 283626

Powered by Google App Engine
This is Rietveld 408576698