Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 395643002: Refactor how WebCrypto NSS and OpenSSL specific files are included by GN build. (Closed)

Created:
6 years, 5 months ago by eroman
Modified:
6 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Refactor how WebCrypto NSS and OpenSSL specific files are included by GN build. This is in anticipation of adding more crypto-library specific files, so the file lists are not duplicated BUG=374912 R=brettw@chromium.org, dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283510

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase onto master #

Patch Set 4 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M content/child/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eroman
6 years, 5 months ago (2014-07-14 23:28:04 UTC) #1
Dirk Pranke
lgtm
6 years, 5 months ago (2014-07-14 23:31:00 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-14 23:34:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/395643002/20001
6 years, 5 months ago (2014-07-14 23:35:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 10:42:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 16:44:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170708) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79885) win_chromium_rel ...
6 years, 5 months ago (2014-07-15 16:44:27 UTC) #7
eroman
Looks like I need approval from a content/OWNERS for the change to BUILD.gn. @brettw, could ...
6 years, 5 months ago (2014-07-15 20:02:00 UTC) #8
brettw
lgtm
6 years, 5 months ago (2014-07-16 19:16:37 UTC) #9
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-16 19:18:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/395643002/60001
6 years, 5 months ago (2014-07-16 19:22:54 UTC) #11
eroman
6 years, 5 months ago (2014-07-16 21:25:04 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 manually as r283510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698