Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 395633012: Allow benchmarks to provide the standard deviation. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Allow benchmarks to provide the standard deviation. Some benchmarks include their own runner which provides an overall average and a standard deviation. This enables extraction of that value similar to the other measurements. These benchmarks should only be run once. If a benchmarks specifies multiple runs and provides a standard deviation, a warning will be issued that makes the build fail on the buildbot side. TEST=python -m unittest run_benchmarks_test BUG=393947 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22424

Patch Set 1 : #

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -15 lines) Patch
M tools/run_benchmarks.py View 1 4 chunks +20 lines, -0 lines 0 comments Download
M tools/unittests/run_benchmarks_test.py View 1 7 chunks +56 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 5 months ago (2014-07-16 08:30:23 UTC) #1
Jakob Kummerow
LGTM except for naming. "stderr" is the standard output stream for error messages (stdout's evil ...
6 years, 5 months ago (2014-07-16 08:38:29 UTC) #2
Michael Achenbach
On 2014/07/16 08:38:29, Jakob wrote: > LGTM except for naming. > > "stderr" is the ...
6 years, 5 months ago (2014-07-16 08:49:04 UTC) #3
Michael Achenbach
6 years, 5 months ago (2014-07-16 08:53:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698