Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 395633003: Enumerate Bluetooth LE services and expose them to chrome.bluetooth API. (Closed)

Created:
6 years, 5 months ago by rpaquay
Modified:
6 years, 5 months ago
Reviewers:
xiyuan, armansito
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enumerate Bluetooth LE services and expose them to chrome.bluetooth API. BUG=388016 TBR=armansito@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284374

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review feedback. #

Patch Set 3 : Fix x64 build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -120 lines) Patch
M device/bluetooth/bluetooth.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 1 chunk +1 line, -8 lines 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M device/bluetooth/bluetooth_init_win.h View 1 chunk +1 line, -0 lines 0 comments Download
A device/bluetooth/bluetooth_low_energy_defs_win.h View 1 chunk +192 lines, -0 lines 0 comments Download
A + device/bluetooth/bluetooth_low_energy_defs_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.h View 1 3 chunks +18 lines, -34 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.cc View 8 chunks +101 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win.h View 3 chunks +12 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win.cc View 1 2 1 chunk +27 lines, -23 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win_unittest.cc View 1 chunk +16 lines, -25 lines 0 comments Download
M device/bluetooth/bluetooth_socket_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.h View 1 chunk +4 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 3 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
rpaquay
6 years, 5 months ago (2014-07-14 23:25:10 UTC) #1
xiyuan
LGTM Sorry for taking so long. It's dropped from my radar somehow. https://codereview.chromium.org/395633003/diff/1/device/bluetooth/bluetooth_low_energy_win.h File device/bluetooth/bluetooth_low_energy_win.h ...
6 years, 5 months ago (2014-07-17 17:47:10 UTC) #2
rpaquay
armansito@chromium.org: Please review (trivial) changes in device/bluetooth/bluetooth.gyp https://codereview.chromium.org/395633003/diff/1/device/bluetooth/bluetooth_low_energy_win.h File device/bluetooth/bluetooth_low_energy_win.h (right): https://codereview.chromium.org/395633003/diff/1/device/bluetooth/bluetooth_low_energy_win.h#newcode12 device/bluetooth/bluetooth_low_energy_win.h:12: #include "bluetooth_low_energy_defs_win.h" ...
6 years, 5 months ago (2014-07-17 18:14:11 UTC) #3
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 5 months ago (2014-07-17 22:04:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/395633003/20001
6 years, 5 months ago (2014-07-17 22:07:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 02:53:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 03:14:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172286)
6 years, 5 months ago (2014-07-18 03:14:48 UTC) #8
armansito
device/bluetooth/bluetooth.gyp lgtm
6 years, 5 months ago (2014-07-18 03:22:03 UTC) #9
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 5 months ago (2014-07-18 17:20:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/395633003/20001
6 years, 5 months ago (2014-07-18 17:22:56 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 17:59:54 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 18:10:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/32250)
6 years, 5 months ago (2014-07-18 18:10:58 UTC) #14
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 5 months ago (2014-07-20 17:31:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/395633003/40001
6 years, 5 months ago (2014-07-20 17:32:25 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-20 21:36:29 UTC) #17
Message was sent while issue was closed.
Change committed as 284374

Powered by Google App Engine
This is Rietveld 408576698