Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/analysis_server/test/search/element_references_test.dart

Issue 395623006: Add hierarchy utils and use them in search. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/search/element_references_test.dart
diff --git a/pkg/analysis_server/test/search/element_references_test.dart b/pkg/analysis_server/test/search/element_references_test.dart
index 85140f541da90d302aecdf771d342b1253e0aa72..578a5a0aa1a2f12a972a6f8dcb0a2f0b5a0a0d86 100644
--- a/pkg/analysis_server/test/search/element_references_test.dart
+++ b/pkg/analysis_server/test/search/element_references_test.dart
@@ -55,59 +55,6 @@ class ElementReferencesTest extends AbstractAnalysisTest {
return createLocalMemoryIndex();
}
- fail_test_hierarchyMembers_field_explicit() {
- // TODO(scheglov) implement
- addTestFile('''
-class A {
- int fff; // in A
-}
-class B extends A {
- int fff; // in B
-}
-class C extends B {
- int fff; // in C
-}
-main(A a, B b, C c) {
- a.fff = 10;
- b.fff = 20;
- c.fff = 30;
-}
-''');
- return findElementReferences('fff; // in B', false).then((_) {
- assertHasResult(SearchResultKind.DECLARATION, 'fff; // in A');
- assertHasResult(SearchResultKind.DECLARATION, 'fff; // in B');
- assertHasResult(SearchResultKind.DECLARATION, 'fff; // in C');
- assertHasResult(SearchResultKind.WRITE, 'fff = 10;');
- assertHasResult(SearchResultKind.WRITE, 'fff = 20;');
- assertHasResult(SearchResultKind.WRITE, 'fff = 30;');
- });
- }
-
- fail_test_hierarchyMembers_method() {
- // TODO(scheglov) implement
- addTestFile('''
-class A {
- mmm() {} // in A
-}
-class B extends A {
- mmm() {} // in B
-}
-class C extends B {
- mmm() {} // in C
-}
-main(A a, B b, C c) {
- a.mmm(10);
- b.mmm(20);
- c.mmm(30);
-}
-''');
- return findElementReferences('mmm() {} // in B', false).then((_) {
- assertHasResult(SearchResultKind.INVOCATION, 'mmm(10)');
- assertHasResult(SearchResultKind.INVOCATION, 'mmm(20)');
- assertHasResult(SearchResultKind.INVOCATION, 'mmm(30)');
- });
- }
-
Future findElementReferences(String search, bool includePotential) {
int offset = findOffset(search);
return waitForTasksFinished().then((_) {
@@ -304,6 +251,57 @@ main() {
});
}
+ test_hierarchy_field_explicit() {
+ addTestFile('''
+class A {
+ int fff; // in A
+}
+class B extends A {
+ int fff; // in B
+}
+class C extends B {
+ int fff; // in C
+}
+main(A a, B b, C c) {
+ a.fff = 10;
+ b.fff = 20;
+ c.fff = 30;
+}
+''');
+ return findElementReferences('fff; // in B', false).then((_) {
+ assertHasResult(SearchResultKind.DECLARATION, 'fff; // in A');
+ assertHasResult(SearchResultKind.DECLARATION, 'fff; // in B');
+ assertHasResult(SearchResultKind.DECLARATION, 'fff; // in C');
+ assertHasResult(SearchResultKind.WRITE, 'fff = 10;');
+ assertHasResult(SearchResultKind.WRITE, 'fff = 20;');
+ assertHasResult(SearchResultKind.WRITE, 'fff = 30;');
+ });
+ }
+
+ test_hierarchy_method() {
+ addTestFile('''
+class A {
+ mmm() {} // in A
+}
+class B extends A {
+ mmm() {} // in B
+}
+class C extends B {
+ mmm() {} // in C
+}
+main(A a, B b, C c) {
+ a.mmm(10);
+ b.mmm(20);
+ c.mmm(30);
+}
+''');
+ return findElementReferences('mmm() {} // in B', false).then((_) {
+ assertHasResult(SearchResultKind.INVOCATION, 'mmm(10)');
+ assertHasResult(SearchResultKind.INVOCATION, 'mmm(20)');
+ assertHasResult(SearchResultKind.INVOCATION, 'mmm(30)');
+ });
+ }
+
test_localVariable() {
addTestFile('''
main() {
« no previous file with comments | « pkg/analysis_server/lib/src/search/element_references.dart ('k') | pkg/analysis_services/lib/index/index.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698