Issue 395613002: Revert of drawVertices bug on gpu side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395613002: Revert of drawVertices bug on gpu side (Closed)

Created:
6 years, 5 months ago by dandov

Modified:
6 years, 5 months ago

Reviewers:
jvanverth1, bsalomon, egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of drawVertices bug on gpu side (https://codereview.chromium.org/387113002/) Reason for revert: compare gms failed on 6 images, I will check them and determine if they need a rebaseline or if the output is incorrect. Original issue's description: > Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices. > > BUG=skia:2745 > > Committed: https://skia.googlesource.com/skia/+/612364de87cb2012239c4f6435e8e11760617fdc TBR=jvanverth@google.com,bsalomon@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2745 Committed: https://skia.googlesource.com/skia/+/49b359079809101e04cbde6c86d3df0ab537cc4a

Created: 6 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -42 lines)			Patch
	M	src/gpu/SkGpuDevice.cpp	View		2 chunks	+20 lines, -42 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dandov@google.com/395613002/1

6 years, 5 months ago (2014-07-14 21:52:33 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-14 21:52:40 UTC) #3

Message was sent while issue was closed.

Change committed as 49b359079809101e04cbde6c86d3df0ab537cc4a