Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: src/core/SkImageFilter.cpp

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: revised understanding : input filter count is requred, but elements may be null Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkImageFilter.cpp
diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp
index 3eb688e2c74d9848cfdd5a0028ecf159db7edfa7..b52976c8e347aa3f13acea981bc30f02bfc0a8f3 100644
--- a/src/core/SkImageFilter.cpp
+++ b/src/core/SkImageFilter.cpp
@@ -39,13 +39,13 @@ void SkImageFilter::Common::detachInputs(SkImageFilter** inputs) {
sk_bzero(fInputs.get(), size);
}
-bool SkImageFilter::Common::unflatten(SkReadBuffer& buffer, int expectedCount) {
+bool SkImageFilter::Common::unflatten(SkReadBuffer& buffer, int expectedInputCount) {
int count = buffer.readInt();
- if (expectedCount < 0) { // means the caller doesn't care how many
- expectedCount = count;
+ if (expectedInputCount < 0) {
+ expectedInputCount = count;
}
- if (!buffer.validate(count == expectedCount)) {
- return false;
+ if (!buffer.validate(count == expectedInputCount)) {
+ return NULL;
}
this->allocInputs(count);
@@ -102,7 +102,7 @@ SkImageFilter::SkImageFilter(int inputCount, SkReadBuffer& buffer) {
}
}
-void SkImageFilter::flatten(SkWriteBuffer& buffer) const {
+void SkImageFilter::flattenCommon(SkWriteBuffer& buffer) const {
buffer.writeInt(fInputCount);
for (int i = 0; i < fInputCount; i++) {
SkImageFilter* input = getInput(i);

Powered by Google App Engine
This is Rietveld 408576698