src/effects/gradients/SkLinearGradient.h - Issue 395603002: Simplify flattening to just write enough to call the factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkLinearGradient.h

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: use friend class instead of function to better hide how we initialize Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkLinearGradient.h

diff --git a/src/effects/gradients/SkLinearGradient.h b/src/effects/gradients/SkLinearGradient.h

index 65d8bfdefa2a9ff77754b612b1dab277dbd0c609..68901064dfcdb3f2f3e3a30abb2205763b413586 100644

--- a/src/effects/gradients/SkLinearGradient.h

+++ b/src/effects/gradients/SkLinearGradient.h

@@ -42,6 +42,7 @@ protected:

virtual Context* onCreateContext(const ContextRec&, void* storage) const SK_OVERRIDE;

private:

+ friend class SkGradientShader;

typedef SkGradientShaderBase INHERITED;

const SkPoint fStart;

const SkPoint fEnd;