src/opts/SkXfermode_opts_arm_neon.cpp - Issue 395603002: Simplify flattening to just write enough to call the factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkXfermode_opts_arm_neon.cpp

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: simplify xfermodes, fix SkLayerDrawLooper Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/opts/SkXfermode_opts_arm_neon.cpp

diff --git a/src/opts/SkXfermode_opts_arm_neon.cpp b/src/opts/SkXfermode_opts_arm_neon.cpp

index 88c179d9e827601fd72002d4dbb84167e4c84ecb..dca58eb53e9ac30b5229ddde0971554ed32e5ca9 100644

--- a/src/opts/SkXfermode_opts_arm_neon.cpp

+++ b/src/opts/SkXfermode_opts_arm_neon.cpp

@@ -743,10 +743,11 @@ typedef uint8x8x4_t (*SkXfermodeProcSIMD)(uint8x8x4_t src, uint8x8x4_t dst);

extern SkXfermodeProcSIMD gNEONXfermodeProcs[];

-SkNEONProcCoeffXfermode::SkNEONProcCoeffXfermode(SkReadBuffer& buffer)

- : INHERITED(buffer) {

+#ifdef SK_SUPPORT_LEGACY_DEEPFLATTENING

+SkNEONProcCoeffXfermode::SkNEONProcCoeffXfermode(SkReadBuffer& buffer) : INHERITED(buffer) {

fProcSIMD = reinterpret_cast<void*>(gNEONXfermodeProcs[this->getMode()]);

}

+#endif

void SkNEONProcCoeffXfermode::xfer32(SkPMColor* SK_RESTRICT dst,

const SkPMColor* SK_RESTRICT src, int count,