include/core/SkXfermode.h - Issue 395603002: Simplify flattening to just write enough to call the factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkXfermode.h

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: simplify xfermodes, fix SkLayerDrawLooper Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkXfermode.h

diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h

index 74fd9f85f7c3a56d80d38231a263e423ac1d46bd..3fb3ab59a79c4e47bd1b0cbc5cb891ece70b5d92 100644

--- a/include/core/SkXfermode.h

+++ b/include/core/SkXfermode.h

@@ -217,7 +217,9 @@ public:

protected:

SkXfermode() {}

+#ifdef SK_SUPPORT_LEGACY_DEEPFLATTENING

explicit SkXfermode(SkReadBuffer& rb) : SkFlattenable(rb) {}

+#endif

/** The default implementation of xfer32/xfer16/xferA8 in turn call this

method, 1 color at a time (upscaled to a SkPMColor). The default