Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: include/effects/SkComposeImageFilter.h

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/effects/SkColorMatrixFilter.h ('k') | include/effects/SkCornerPathEffect.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkComposeImageFilter_DEFINED 8 #ifndef SkComposeImageFilter_DEFINED
9 #define SkComposeImageFilter_DEFINED 9 #define SkComposeImageFilter_DEFINED
10 10
11 #include "SkImageFilter.h" 11 #include "SkImageFilter.h"
12 12
13 class SK_API SkComposeImageFilter : public SkImageFilter { 13 class SK_API SkComposeImageFilter : public SkImageFilter {
14 public: 14 public:
15 virtual ~SkComposeImageFilter(); 15 virtual ~SkComposeImageFilter();
16 16
17 static SkComposeImageFilter* Create(SkImageFilter* outer, SkImageFilter* inn er) { 17 static SkImageFilter* Create(SkImageFilter* outer, SkImageFilter* inner) {
18 if (NULL == outer) {
19 return SkSafeRef(inner);
20 }
21 if (NULL == inner) {
22 return SkRef(outer);
23 }
18 SkImageFilter* inputs[2] = { outer, inner }; 24 SkImageFilter* inputs[2] = { outer, inner };
19 return SkNEW_ARGS(SkComposeImageFilter, (inputs)); 25 return SkNEW_ARGS(SkComposeImageFilter, (inputs));
20 } 26 }
21 27
22 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkComposeImageFilter) 28 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkComposeImageFilter)
23 29
24 protected: 30 protected:
25 explicit SkComposeImageFilter(SkImageFilter* inputs[2]) : INHERITED(2, input s) {} 31 explicit SkComposeImageFilter(SkImageFilter* inputs[2]) : INHERITED(2, input s) {
32 SkASSERT(inputs[0]);
33 SkASSERT(inputs[1]);
34 }
35 #ifdef SK_SUPPORT_LEGACY_DEEPFLATTENING
26 explicit SkComposeImageFilter(SkReadBuffer& buffer); 36 explicit SkComposeImageFilter(SkReadBuffer& buffer);
37 #endif
27 38
28 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, 39 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
29 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E; 40 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E;
30 virtual bool onFilterBounds(const SkIRect&, const SkMatrix&, SkIRect*) const SK_OVERRIDE; 41 virtual bool onFilterBounds(const SkIRect&, const SkMatrix&, SkIRect*) const SK_OVERRIDE;
31 42
32 private: 43 private:
33 typedef SkImageFilter INHERITED; 44 typedef SkImageFilter INHERITED;
34 }; 45 };
35 46
36 #endif 47 #endif
OLDNEW
« no previous file with comments | « include/effects/SkColorMatrixFilter.h ('k') | include/effects/SkCornerPathEffect.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698