Simplify flattening to just write enough to call the factory

gm/gradients_2pt_conical.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "gm.h"
 #include "SkGradientShader.h"
 
@@ skipping 314 matching lines @@
             { SkIntToScalar(100), SkIntToScalar(100) }
         };
         SkShader::TileMode tm = SkShader::kClamp_TileMode;
         SkRect r = { 0, 0, SkIntToScalar(100), SkIntToScalar(100) };
         SkPaint paint;
         paint.setAntiAlias(true);
 
         canvas->translate(SkIntToScalar(20), SkIntToScalar(20));
 
         const GradMaker* gradMaker = gGradCases[fGradCaseType].fMaker;
         const int count = gGradCases[fGradCaseType].fCount;

[sugoi1, 2014/08/19 18:46:16]

This may have been mentioned earlier in the review, but why is "count" computed
only the be multiplied by 0 later on?

 
         for (size_t i = 0; i < SK_ARRAY_COUNT(gGradData); i++) {
             canvas->save();

[robertphillips, 2014/08/19 15:23:27]

Why are we skipping these cases now ?

[reed1, 2014/08/19 19:58:05]

debugging. fixed.

-            for (int j = 0; j < count; j++) {
+            for (int j = 1; j < 2+0*count; j++) {
                 SkMatrix scale = SkMatrix::I();
 
                 if (i == 3) { // if the clamp case
                     scale.setScale(0.5f, 0.5f);
                     scale.postTranslate(25.f, 25.f);
                 }
 
                 SkShader* shader = gradMaker[j](pts, gGradData[i], tm, scale);
                 paint.setShader(shader);
                 canvas->drawRect(r, paint);
@@ skipping 15 matching lines @@
 
 static GM* MyFactory1(void*) { return new ConicalGradientsGM(kInside_GradCaseType); }
 static GMRegistry reg1(MyFactory1);
 
 static GM* MyFactory2(void*) { return new ConicalGradientsGM(kOutside_GradCaseType); }
 static GMRegistry reg2(MyFactory2);
 
 static GM* MyFactory3(void*) { return new ConicalGradientsGM(kEdge_GradCaseType); }
 static GMRegistry reg3(MyFactory3);
 }