Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: src/effects/SkPictureImageFilter.cpp

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The Android Open Source Project 2 * Copyright 2013 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkPictureImageFilter.h" 8 #include "SkPictureImageFilter.h"
9 #include "SkDevice.h" 9 #include "SkDevice.h"
10 #include "SkCanvas.h" 10 #include "SkCanvas.h"
(...skipping 13 matching lines...) Expand all
24 : INHERITED(0, 0), 24 : INHERITED(0, 0),
25 fPicture(picture), 25 fPicture(picture),
26 fCropRect(cropRect) { 26 fCropRect(cropRect) {
27 SkSafeRef(fPicture); 27 SkSafeRef(fPicture);
28 } 28 }
29 29
30 SkPictureImageFilter::~SkPictureImageFilter() { 30 SkPictureImageFilter::~SkPictureImageFilter() {
31 SkSafeUnref(fPicture); 31 SkSafeUnref(fPicture);
32 } 32 }
33 33
34 #ifdef SK_SUPPORT_LEGACY_DEEPFLATTENING
34 SkPictureImageFilter::SkPictureImageFilter(SkReadBuffer& buffer) 35 SkPictureImageFilter::SkPictureImageFilter(SkReadBuffer& buffer)
35 : INHERITED(0, buffer), 36 : INHERITED(0, buffer),
36 fPicture(NULL) { 37 fPicture(NULL) {
37 if (!buffer.isCrossProcess()) { 38 if (!buffer.isCrossProcess()) {
38 if (buffer.readBool()) { 39 if (buffer.readBool()) {
39 fPicture = SkPicture::CreateFromBuffer(buffer); 40 fPicture = SkPicture::CreateFromBuffer(buffer);
40 } 41 }
41 } else { 42 } else {
42 buffer.validate(!buffer.readBool()); 43 buffer.validate(!buffer.readBool());
43 } 44 }
44 buffer.readRect(&fCropRect); 45 buffer.readRect(&fCropRect);
45 } 46 }
47 #endif
48
49 SkFlattenable* SkPictureImageFilter::CreateProc(SkReadBuffer& buffer) {
50 SkAutoTUnref<SkPicture> picture;
51 SkRect cropRect;
52
53 if (!buffer.isCrossProcess()) {
54 if (buffer.readBool()) {
55 picture.reset(SkPicture::CreateFromBuffer(buffer));
56 }
57 } else {
58 buffer.validate(!buffer.readBool());
59 }
60 buffer.readRect(&cropRect);
61
62 return Create(picture, cropRect);
63 }
46 64
47 void SkPictureImageFilter::flatten(SkWriteBuffer& buffer) const { 65 void SkPictureImageFilter::flatten(SkWriteBuffer& buffer) const {
48 this->INHERITED::flatten(buffer);
49 if (!buffer.isCrossProcess()) { 66 if (!buffer.isCrossProcess()) {
50 bool hasPicture = (fPicture != NULL); 67 bool hasPicture = (fPicture != NULL);
51 buffer.writeBool(hasPicture); 68 buffer.writeBool(hasPicture);
52 if (hasPicture) { 69 if (hasPicture) {
53 fPicture->flatten(buffer); 70 fPicture->flatten(buffer);
54 } 71 }
55 } else { 72 } else {
56 buffer.writeBool(false); 73 buffer.writeBool(false);
57 } 74 }
58 buffer.writeRect(fCropRect); 75 buffer.writeRect(fCropRect);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 offset->fY = bounds.fTop; 112 offset->fY = bounds.fTop;
96 return true; 113 return true;
97 } 114 }
98 115
99 bool SkPictureImageFilter::onFilterBounds(const SkIRect& src, const SkMatrix& ct m, 116 bool SkPictureImageFilter::onFilterBounds(const SkIRect& src, const SkMatrix& ct m,
100 SkIRect* dst) const { 117 SkIRect* dst) const {
101 *dst = src; 118 *dst = src;
102 return true; 119 return true;
103 } 120 }
104 121
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698